Skip to content

Comments

Token ruffing, added tests#1857

Merged
tykling merged 10 commits intomainfrom
ruff_tokens
May 14, 2025
Merged

Token ruffing, added tests#1857
tykling merged 10 commits intomainfrom
ruff_tokens

Conversation

@zarya
Copy link
Collaborator

@zarya zarya commented May 13, 2025

No description provided.

@zarya zarya marked this pull request as ready for review May 13, 2025 19:56
@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 54.05405% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.44%. Comparing base (c0d6a67) to head (1dabf5b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tokens/models.py 35.71% 9 Missing ⚠️
src/tokens/views.py 44.44% 5 Missing ⚠️
src/tokens/templatetags/token_tags.py 60.00% 2 Missing ⚠️
src/tokens/admin.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   63.46%   63.44%   -0.02%     
==========================================
  Files         665      665              
  Lines       16112    16128      +16     
==========================================
+ Hits        10225    10233       +8     
- Misses       5887     5895       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

except CampReadOnlyModeError:
raise Http404
except CampReadOnlyModeError as e:
raise Http404 from e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Copy link
Member

@tykling tykling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent 💯

@tykling tykling merged commit 30a40d9 into main May 14, 2025
1 of 3 checks passed
@tykling tykling deleted the ruff_tokens branch May 14, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants